Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update vitest to support vite v6 #1108

Closed
wants to merge 1 commit into from
Closed

chore: update vitest to support vite v6 #1108

wants to merge 1 commit into from

Conversation

deboer-tim
Copy link
Contributor

What does this PR do?

Vite was updated from v5 to v6, and vitest needs to be updated to match. vitest 2.2 added and then removed the support; 3.0 will add it but is still in beta until January.

Screenshot / video of UI

N/A

What issues does this PR fix or reference?

Fixes #1107.

How to test this PR?

PR checks are enough.

Vite was updated from v5 to v6, and vitest needs to be updated to match.
vitest 2.2 added and then removed the support; 3.0 will add it but is still in
beta until January.

Signed-off-by: Tim deBoer <[email protected]>
@cdrage
Copy link
Contributor

cdrage commented Dec 18, 2024

Failing 1 test, can confirm it's working fine though / able to do all the features from the looks of it via testing.

Should we disable the test + open up an issue to fix it so we can merge the other two PR's as well for the release? @deboer-tim

@cdrage
Copy link
Contributor

cdrage commented Dec 19, 2024

Closing / replaced by #1116

@cdrage cdrage closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bootc extension won't load from main branch
2 participants